Repository navigation
style: lint the train test files now that train/ is in scope - #214
Merged
Merged
Conversation
#209 removed `train` from the ruff exclude list, and #205/#206 added these two test files while it was still excluded, so they had never been checked. Together on main they fail CI: train/tests/test_loss_world_size.py:26:33: RUF100 Unused `noqa` directive 2 files would be reformatted Each PR was green on its own; the combination was what nobody ran. Fixed with `ruff check --fix` and `ruff format` over train/tests/ only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently failingPython lint. #209 removedtrainfrom the ruff exclude list; #205 and #206 addedtrain/tests/test_loss_world_size.pyandtrain/tests/test_loss_fn_wiring.pywhile it was still excluded, so those files had never been linted.Each PR was green on its own branch — the combination is what nobody ran, including me when I merged them.
Fixed with
ruff check --fixandruff formatscoped totrain/tests/. After it:ruff check .— all checks passedruff format --check .— 205 files already formatteduv run pytest tests/— 362 passed, 3 skipped🤖 Generated with Claude Code